-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade to pom-scijava 29 #42
Conversation
@frauzufall with new releases of |
@imagejan I will update the versions and let the tests speak :) Thank you so much for reviewing and releasing all of this! |
- upgrade pom-scijava to 29.2.1 - upgrade dropwizard from 1.2.0 to 2.0.9 - upgrade jersey-media-multipart from 2.23.2 to 2.31 - use jackson version 2.11.2 - delete DefaultTableIOPlugin, use TableIOService instead - make TableIOPluginTest use new options API for reading and writing tables - use BytesHandle instead of ByteArrayHandle
I tested all the main APIs documented in the README. Some of the The good news: All the I/O-related endpoints still work! 🎉 And the SciJava module-related endpoints work too! 🎉 The bad news: The
Returns nothing. But the server does not stop, and on the server side we see:
It looks to me like some version skew across Dropwizard dependencies. @frauzufall I noticed that you stopped using the |
This makes the /admin/stop endpoint functional again.
After 69d73f5, I was able to use |
This PR depends on the following PRs:
Outline of the changes:
pom-scijava to 29.2.1
dropwizard
from1.2.0
to2.0.9
jersey-media-multipart
from2.23.2
to2.31
jackson
version2.11.2
DefaultTableIOPlugin
, useTableIOService
insteadTableIOPluginTest
use new options API for reading and writing tablesBytesHandle
instead ofByteArrayHandle
All tests run successfully for me now with the branches from the other PRs, but since I never used
imagej-server
for anything, it'd be great to have a real world tester :) And of course, all of the above PRs first need to be reviewed before this can be finished.Here are the JARs if anyone wants to give it a try:
imagej-server-pom-sj-29.zip