feat: Add 25Mar2020 Virtual Session fields for non-offline sessions #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lukehesluke
commented
Mar 27, 2020
| @@ -119,7 +124,7 @@ function generateOffer(age, baseUrl, modified, golden, free) { | |||
|
|
|||
| function generateImages(golden) { | |||
| var out = []; | |||
| var imageCount = faker.random.number(golden ? {min: 4, max: 6} : 6); | |||
| var imageCount = faker.random.number(golden ? {min: 4, max: 6} : { max: 6 }); | |||
There was a problem hiding this comment.
My error checker gets confused when function call signatures are mixed with a single call (i.e. number(max: number) vs number({ max: number, min: number })).
So I've updated it to both use the same signature (with the min/max object)
lukehesluke
commented
Mar 27, 2020
| var startDate = moment.tz(startDateString, tzid); | ||
| var endDate = startDate.clone().add(moment.duration(duration)); | ||
| /** | ||
| * @param {Date} startDate |
There was a problem hiding this comment.
This was not a string - it was a Date
lukehesluke
commented
Mar 27, 2020
Comment on lines
+462
to
+545
| /** | ||
| * @param {string} orgBaseUrl | ||
| * @param {boolean} golden | ||
| */ | ||
| function generatePlace(orgBaseUrl, golden) { | ||
| var siteName = faker.address.streetName() + " " + faker.random.arrayElement(["Sports Village", "Leisure Centre", "Centre"]); | ||
| var postcodeObj = postcodes[faker.random.number(postcodes.length - 1)]; | ||
| return { | ||
| "type": "Place", | ||
| "url": orgBaseUrl + "/" + faker.random.arrayElement(["sites", "centres", "locations"]) + "/" + faker.helpers.slugify(siteName.toLowerCase()), | ||
| "name": siteName, | ||
| "description": faker.lorem.paragraphs(golden ? 4 : faker.random.number(4)), | ||
| "identifier": faker.finance.bic(), | ||
| "address": { | ||
| "type": "PostalAddress", | ||
| "streetAddress": faker.address.streetAddress(), | ||
| "addressLocality": "Oxford", | ||
| "addressRegion": "Oxfordshire", | ||
| "postalCode": postcodeObj.postcode, | ||
| "addressCountry": "GB" | ||
| }, | ||
| "telephone": faker.phone.phoneNumber(), | ||
| "geo": { | ||
| "type": "GeoCoordinates", | ||
| "latitude": postcodeObj.latitude, | ||
| "longitude": postcodeObj.longitude | ||
| }, | ||
| "image": generateImages(), | ||
| "amenityFeature": generateAmenityFeature(golden), | ||
| "openingHoursSpecification": [ | ||
| { | ||
| "type": "OpeningHoursSpecification", | ||
| "dayOfWeek": "https://schema.org/Sunday", | ||
| "opens": "09:00", | ||
| "closes": "17:30" | ||
| }, | ||
| { | ||
| "type": "OpeningHoursSpecification", | ||
| "dayOfWeek": "https://schema.org/Monday", | ||
| "opens": "06:30", | ||
| "closes": "21:30" | ||
| }, | ||
| { | ||
| "type": "OpeningHoursSpecification", | ||
| "dayOfWeek": "https://schema.org/Tuesday", | ||
| "opens": "06:30", | ||
| "closes": "21:30" | ||
| }, | ||
| { | ||
| "type": "OpeningHoursSpecification", | ||
| "dayOfWeek": "https://schema.org/Wednesday", | ||
| "opens": "06:30", | ||
| "closes": "21:30" | ||
| }, | ||
| { | ||
| "type": "OpeningHoursSpecification", | ||
| "dayOfWeek": "https://schema.org/Thursday", | ||
| "opens": "06:30", | ||
| "closes": "21:30" | ||
| }, | ||
| { | ||
| "type": "OpeningHoursSpecification", | ||
| "dayOfWeek": "https://schema.org/Friday", | ||
| "opens": "06:30", | ||
| "closes": "20:30" | ||
| }, | ||
| { | ||
| "type": "OpeningHoursSpecification", | ||
| "dayOfWeek": "https://schema.org/Saturday", | ||
| "opens": "07:15", | ||
| "closes": "17:30" | ||
| } | ||
| ] | ||
| }; | ||
| } | ||
|
|
There was a problem hiding this comment.
This is an exact copy of the Place object that was created in generateSessionSeriesItemData. I have made no updates to it other than moving it into its own function
lukehesluke
force-pushed
the
feature/virtual-fields
branch
from
a471fb9 to
94277ef
Compare
…rable-sessionseries-dates feat: Configure timestamp and schedule generation for SessionSeries feed
lukehesluke
force-pushed
the
feature/virtual-fields
branch
from
94277ef to
b530461
Compare
lukehesluke
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
QA
Example of a golden session:
Online sessions have no
location:Example of an affiliated location: