Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Jupyterlab>4 #7

Merged
merged 7 commits into from
Apr 5, 2024
Merged

Support Jupyterlab>4 #7

merged 7 commits into from
Apr 5, 2024

Conversation

oeway
Copy link
Contributor

@oeway oeway commented Apr 4, 2024

This PR is to support Jupyterlab>4.

Some notes on the implementation:
I had to create a complete new project using the template: https://github.com/jupyterlab/extension-template

After testing it locally, I cannot upload the package to pypi using twine, because the default build system for jupyterlab extension project is hatch and they recently bumped the default metadata version to 2.3, and that is not supported by twine (even though no error was printed about the unsupported metadata version), the error I got was:

ERROR    InvalidDistribution: Metadata is       
         missing required fields: Name, Version.
         Make sure the distribution includes the
         files where those fields are specified,
         and is using a supported               
         Metadata-Version: 1.0, 1.1, 1.2, 2.0,  
         2.1, 2.2. 

I spent hours to dig into the issue and finally identified that the issue was in the recent version of hatchling, this was the fix: hatchling>=1.5.0,<1.22.2.

Closes #4

Copy link

github-actions bot commented Apr 4, 2024

Binder 👈 Launch a Binder on branch imjoy-team/imjoy-jupyterlab-extension/jupyterlab-4

@oeway oeway merged commit 87b8b24 into main Apr 5, 2024
1 of 4 checks passed
thewtex added a commit to thewtex/itkwidgets that referenced this pull request Apr 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

No joy yet with version 0.1.20
1 participant