Skip to content
This repository has been archived by the owner on Dec 12, 2024. It is now read-only.

Refactor type of dimension attributes in TOSA reference implementation #418

Merged
merged 2 commits into from
Apr 4, 2024
Merged

Refactor type of dimension attributes in TOSA reference implementation #418

merged 2 commits into from
Apr 4, 2024

Conversation

henri-gruender
Copy link
Member

@henri-gruender henri-gruender commented Apr 4, 2024 •
edited by marbre
Loading

Closes #390.

marbre
marbre approved these changes Apr 4, 2024
View reviewed changes
Copy link
Contributor

@marbre marbre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, assuming that all test pass :)

@marbre
Copy link
Contributor

marbre commented Apr 4, 2024

I'll merge as soon as we tested with an updated, cached LLVM.

@marbre marbre enabled auto-merge (squash) April 4, 2024 12:37
@marbre marbre merged commit f896d3f into iml130:main Apr 4, 2024
6 checks passed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@simon-camp simon-camp simon-camp approved these changes

@marbre marbre marbre approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Refactor types of attributes passed in TOSA reference implementation
3 participants
@henri-gruender @marbre @simon-camp