-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add linting workflow to CI #13
Conversation
How does this action work? Does it just run the linter (I am not familiar with typescript at all)? If yes, the linter will probably always pass if it isn't segfaulting. This means you need to check if there are changes to a prior / the checkin revision. |
The command eslint ./ (triggered by npm run lint) should check the code for linting errors according to the rules defined in the .eslintrc.js and return an error code if errors are found. Therefore the job should fail when linting errors exist. |
As you say should, you don't seem to be 100% confident. What about introducing a formatting error in an additional commit to test the pipeline? This commit can be dropped before merging. |
The workflow acts as expected (See the workflow for the code containing a formatting error) |
7d60dc8
to
725f140
Compare
Run ESLint check when relevant files are changed.