Fix copyright notice #16
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This should probably be `PFDL VS Code Extension Contributors` as these are only a subgroup of the `PDFL Contributors`. The former is used for nearly all other files, expect for PFDL code samples.
There was a problem hiding this comment.
This file was generated via the PFDL Scheduler, based on an example file in the PFDL repository (https://github.com/iml130/pfdl/blob/main/examples/simple_task.pfdl). But I agree with your suggestion as this file content does not appear anywhere else.
There was a problem hiding this comment.
Both is actually fine, but let's wait on @ptrdtznr opinion though before merging. If we a reply takes to ling I can also split this and send a separate PR for this.
There was a problem hiding this comment.
TBH, I dont really have an opinion. Lets keep it pragmatic and easiest, correct way.
OliverStolzBO
approved these changes
Feb 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should probably be
PFDL VS Code Extension Contributorsas these are only a subgroup of thePDFL Contributors. The former is used for nearly all other files, expect for PFDL code samples.