Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use separate ns-3 applications for different OptiMaFlow agents/assets #119

Merged
merged 1 commit into from
Sep 25, 2023

Conversation

ltoenning
Copy link
Member

⚠️ This PR depends on #117 which must be merged first ⚠️

Proposed Changes

This PR introduces separate ns-3 applications for

  • AmrLogicalAgent
  • AmrPhysicalAsset
  • MaterialFlowLogicalAgent

to avoid requiring a std::variant with many different types in a single CppsApplication.

Related to #105.

Definition of Done (optional)

  • Feature is implemented
  • No known bugs that stops the correct execution
  • CI / CD pipeline passed
  • The code guidelines were followed
  • [ ] Unit and / or Integration tests for the new feature
  • [ ] New feature was added to the documentation

@ltoenning ltoenning self-assigned this Sep 18, 2023
@ltoenning ltoenning changed the title Use separate Use separate ns-3 applications for different OptiMaFlow agents/assets Sep 18, 2023
@ltoenning ltoenning force-pushed the ns3_application_refactoring branch from fe4b4ff to efdebe1 Compare September 22, 2023 15:27
@ltoenning ltoenning marked this pull request as ready for review September 22, 2023 15:31
@ltoenning ltoenning merged commit 9174c2b into iml130:main Sep 25, 2023
@ltoenning ltoenning deleted the ns3_application_refactoring branch September 25, 2023 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants