-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
migrate to ethers v6 #2374
base: feat/major-poc
Are you sure you want to change the base?
migrate to ethers v6 #2374
Conversation
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 015ec60. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 2 targetsSent with 💌 from NxCloud. |
8bf5e2c
to
152ea6f
Compare
d00fbd7
to
1c0a592
Compare
c0b21c8
to
935c9d5
Compare
a6c281e
to
bdafd2d
Compare
1ac7dfe
to
3654777
Compare
cb7c27d
to
c0d1cfb
Compare
37a6202
to
33bbb5b
Compare
b094201
to
2d08363
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The orderbook updates make sense to me. One nit around remaining v5 naming that doesnt apply anymore
callerAddress: string, | ||
): TransactionBuilder { | ||
return async () => { | ||
const v6ContractTransaction = await transactionMethods.buildTransaction(); | ||
|
||
const v5PopulatedTransaction: PopulatedTransaction = { | ||
const v5PopulatedTransaction: PreparedTransactionRequest = { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: this is no longer a v5 transaction mapping layer, so a rename through here would be clearer
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cheers, addressed this issue 😄
f4ab878
to
140adfc
Compare
Co-authored-by: zaid.arain <[email protected]> Co-authored-by: Luã de Souza <[email protected]>
140adfc
to
d321490
Compare
No description provided.