EDSF-374 Verify that required=True in ArgumentParser works

imperva · Nov 1, 2023 · 333c9a3 · 333c9a3
1 parent 5cc352f
commit 333c9a3
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 7 deletions.
diff --git a/modules/aws/sonar-upgrader/main.tf b/modules/aws/sonar-upgrader/main.tf
@@ -9,7 +9,7 @@ locals {
     run_preflight_validations  = var.run_preflight_validations
     run_upgrade                = var.run_upgrade
     run_postflight_validations = var.run_postflight_validations
-    clean_old_deployments      = var.clean_old_deployments
+#    clean_old_deployments      = var.clean_old_deployments
     stop_on_failure            = var.stop_on_failure
     tarball_location           = jsonencode(var.tarball_location)
   })

diff --git a/modules/aws/sonar-upgrader/provision_script.tpl b/modules/aws/sonar-upgrader/provision_script.tpl
@@ -17,6 +17,5 @@ PYTHONPATH=${path}/python_upgrader python3 -u -m upgrade.main \
   --run_preflight_validations "${run_preflight_validations}" \
   --run_upgrade "${run_upgrade}" \
   --run_postflight_validations "${run_postflight_validations}" \
-  --clean_old_deployments "${clean_old_deployments}" \
   --stop_on_failure "${stop_on_failure}" \
   --tarball_location '${tarball_location}'
diff --git a/modules/aws/sonar-upgrader/variables.tf b/modules/aws/sonar-upgrader/variables.tf
@@ -110,11 +110,11 @@ variable "run_postflight_validations" {
   description = "Whether to run the postflight validations or skip them"
 }
 
-variable "clean_old_deployments" {
-  type        = bool
-  default     = false
-  description = "Whether to clean old deployments after successful upgrade. In case postflight validations run and failed, old deployment directories cleaning will be skipped. This variable is not operational in this POC."
-}
+#variable "clean_old_deployments" {
+#  type        = bool
+#  default     = false
+#  description = "Whether to clean old deployments after successful upgrade. In case postflight validations run and failed, old deployment directories cleaning will be skipped. This variable is not operational in this POC."
+#}
 
 
 variable "stop_on_failure" {