Added support for DAM 14.7 (LTS) #318
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
assaf13
reviewed
Nov 19, 2023
modules/aws/mx/hub.tf
Outdated
| dam_version = "${local.dam_version_major}.${local.dam_version_minor}" | ||
| # Archiving action set is created differently on 14.7 | ||
|
|
||
| action_set_item = var.hub_details == [] ? null : local.dam_version != "14.7" ? [{ |
There was a problem hiding this comment.
The condition here is different than hub_configuration = var.hub_details == null ? [] : concat...
Is it ok ?
There was a problem hiding this comment.
You are absolutely right. Fixing.
assaf13
reviewed
Nov 19, 2023
| "strictCertificateChecking" : false | ||
| "actionInterface": "Send to Sonar" | ||
| } | ||
| ) |
There was a problem hiding this comment.
Does the only difference at the payload is that it conains actionInterface and missing enabled ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.