-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
simplify remote executor #382
Conversation
I see a failure with create terraform that seems unrelated to these changes |
I see two actions failed, one failure in DAM so not related: https://github.com/imperva/dsfkit/actions/runs/7876864234/job/21491779160#step:21:10113 This looks related to the change. |
@lindanasredin I've already fixed and rerun those tests https://github.com/imperva/dsfkit/actions/runs/7877609163 |
Related to https://onejira.imperva.com/browse/SD-1064
Standardize getting paramiko client. Create
remote_client_context
to return a client with or without proxy, and cleanup afterwards.As well, added some
raise from
to improve debugging.This is the prequal to using the paramiko client for more things, so simplifying how to create one is important.