Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README.md #411

Merged
merged 6 commits into from
May 15, 2024
Merged

Update README.md #411

merged 6 commits into from
May 15, 2024

Conversation

idannof-imperva
Copy link
Collaborator

change sort order of "AWS Examples" section: move deployments that include all DSF components to appear first.

change sort order of "AWS Examples" section: move deployments that include all DSF components to appear first.
@lindanasredin
Copy link
Collaborator

I think it's better to put the PS/Customer examples before the POC/Lab ones because they are the main use case. So the overall order I'm suggesting is: DSF Single Account, DSF, Sonar Single Account, Sonar Multi Account, Sonar Basic, Sonar HADR, Sonar Upgrade. Please remove the Alpha from Sonar Upgrade while you're at it, it's there by mistake. Please also change the order in step 9 of "Installer Machine Deployment Mode".

changes following code review
apply changes from open PR for EDSF-495
@lindanasredin
Copy link
Collaborator

Please don't include the tree/raw change in this PR, I'm not sure it's valid. If necessary Gabi will create his PR again after your change. You can drop him a note if you want.

revert previous commit
revert to commit 9e7688d
@lindanasredin
Copy link
Collaborator

Thanks a lot for replacing the sonar_basic_deployment with dsf_single_account_deployment, I thought it was too much so I didn't. However, it is better to put dsf_deployment because dsf_single_account_deployment requires additional steps - the user needs to provide the network infrastructure as input variables. Thank you you for your patience.

code review adjustments
@idannof-imperva idannof-imperva merged commit b64e3cc into dev May 15, 2024
8 checks passed
@idannof-imperva idannof-imperva deleted the idannof-aws-examples-order branch May 15, 2024 08:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants