Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

allow date suffixes in upgrade script #432

Merged
merged 1 commit into from
Aug 22, 2024
Merged

allow date suffixes in upgrade script #432

merged 1 commit into from
Aug 22, 2024

Conversation

jsonar-cpapke
Copy link
Collaborator

@jsonar-cpapke jsonar-cpapke commented Jul 30, 2024 •
edited
Loading

@jsonar-cpapke jsonar-cpapke requested review from jagdeep-sonar and a team July 30, 2024 18:20
@jsonar-cpapke jsonar-cpapke force-pushed the cpapke/upgrade-allow-date-suffix branch from 0543fb2 to 58c5794 Compare July 30, 2024 18:21
gabibeyo
gabibeyo requested changes Aug 18, 2024
View reviewed changes
Copy link
Collaborator

@gabibeyo gabibeyo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can't see that the Actions did run.

@jsonar-cpapke
Copy link
Collaborator Author

Job has been run and passed

@gabibeyo
Copy link
Collaborator

Approved by me, the PR is awaiting @jagdeep-sonar

jagdeep-sonar
jagdeep-sonar approved these changes Aug 22, 2024
View reviewed changes
Copy link
Collaborator

@jagdeep-sonar jagdeep-sonar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok.

@jsonar-cpapke jsonar-cpapke merged commit 28a1057 into dev Aug 22, 2024
5 checks passed
@jsonar-cpapke jsonar-cpapke deleted the cpapke/upgrade-allow-date-suffix branch August 22, 2024 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jagdeep-sonar jagdeep-sonar jagdeep-sonar approved these changes

@gabibeyo gabibeyo gabibeyo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jsonar-cpapke @gabibeyo @jagdeep-sonar