Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: mysql information displays properly in WP 6.4 #7074

Merged
merged 1 commit into from
Oct 27, 2023

Conversation

JasonTheAdams
Copy link
Contributor

@JasonTheAdams JasonTheAdams commented Oct 26, 2023

Description

WordPress has held backwards compatibility for the MySQL PHP extension for a long time, and provided the $wpdb->use_mysqli property as a way of checking if a WP instance is using the old extension, or the new(er) mysqli extension.

In WP 6.4, support for the old extension is being dropped, due to the fact that the extension doesn't exist in PHP 7.0, which is the new minimum required version of WordPress. With this, WP is also dropping the $wpdb->use_mysqli property because it's meaningless.

Our code was using both that property and, conditionally, the function the used the old extension. Since we don't support <PHP 7.2, we can also drop the use of that function and WP property.

Affects

The MySQL portion of the system info page

Testing Instructions

Make sure that the MySQL info loads properly on WP 6.3 and 6.4.

Pre-review Checklist

@pauloiankoski pauloiankoski self-requested a review October 26, 2023 23:00
Copy link
Contributor

@pauloiankoski pauloiankoski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lovely deletion PR.

Copy link
Member

@rickalday rickalday left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Passed manual QA tests.

@JasonTheAdams JasonTheAdams merged commit 8dbe0be into release/3.1.0 Oct 27, 2023
21 checks passed
@JasonTheAdams JasonTheAdams deleted the fix/remove-mysql-ext-dependency branch October 27, 2023 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants