Fix: Update styles for archive campaign modal UI #7618
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jdghinson
changed the title
There was a problem hiding this comment.
Love the tweaking, @jdghinson! Left a comment for educational and consideration purposes. 😄
src/Campaigns/resources/admin/components/CampaignDetailsPage/CampaignDetailsPage.module.scss
Outdated
Show resolved
Hide resolved
jdghinson
requested review from
jonwaldstein
and removed request for
pauloiankoski
| @@ -185,38 +185,48 @@ select[name="campaignId"] { | |||
| font-size: 16px; | |||
| font-weight: 500; | |||
| line-height: 1.5; | |||
| padding: var(--givewp-spacing-3); | |||
| color: #1f2937; | |||
There was a problem hiding this comment.
@jdghinson I'm guessing we just don't have a design system color we want to use here?
There was a problem hiding this comment.
Nice! 🎉
As a friendly note, @jdghinson, now that you're a dope dev-design unicorn, the convention we use is to include the hash in the follow up comment that is intended to resolve the comment. For example, for this comment you'd say something like:
Resolved in 0fc7b20
😃
JasonTheAdams
approved these changes
Nov 15, 2024
There was a problem hiding this comment.
Fantastic work, @jdghinson! The UI is even more polished and the code is even better because you worked on it.
|
Thank you!! @JasonTheAdams |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR updates the archive campaign modal UI to match the designs in Zeplin. I also added hover states to both the cancel and archive campaign button. Updated our design system to make good use of the neutral colors.
Affects
Affects the archive campaign modal in campaigns.
Visuals
Before
https://www.loom.com/share/53b768c90434437d98e051f201e0043d?sid=33dc9237-5ef4-43e4-9339-fad58f813c99
After
https://www.loom.com/share/293a55f6123b42fdb9a5eb53b1496166?sid=c84b8d6c-94f0-4519-803d-debf2e7bd8ed
Testing Instructions
Pre-review Checklist
@unreleasedtags included in DocBlocks