Refactor: update meta persistence in donor and donation repositories #7679
+65
−25
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partially Resolves GIVE-2075
Description
This updates our donor and donation repositories to use the native WP meta functions for adding meta instead of directly inserting using SQL.
Before this, we were innocently deviating from how WordPress stores meta values, effectively bypasses some of the extra filters/sanitization of values. This resulted in problems downstream when retrieving the data.
So the lesson learned here is to always use the native WordPress api functions for storing and retrieving meta 😄.
Affects
Visuals
Testing Instructions
Make sure both v2 and v3 forms are working as expected.
Pre-review Checklist
@unreleased
tags included in DocBlocks