Refactor: update text block conversion to use text block type #7697
+107
−20
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #
Description
This updates the text block conversion to use the first class
TextBlockType
.This is the first in series approach to moving away from the untyped
$block->getAttribute()
and toward specific block types with typed block attributes in the form of object properties.This also caught and fixes an issue with the
BlockType
class so it will always cast values as intended. So if you are expecting a boolean and for some reason the block does not have the attribute it will still return a boolean type instead of null. This makes sure the block type property types are always valid types and can be confidently used in typed methods in the fields api.Affects
Visuals
N/A
Testing Instructions
Pre-review Checklist
@unreleased
tags included in DocBlocks