Feature: Campaign Goal Block #7702
Open
+351
−13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lock-GIVE-1510 # Conflicts: # src/Campaigns/Blocks/blocks.ts
…lock-GIVE-1510 # Conflicts: # src/Campaigns/Blocks/blocks.ts # src/Campaigns/Controllers/CampaignRequestController.php
pauloiankoski
requested changes
Feb 3, 2025
|
@pauloiankoski this is ready for review |
…lock-GIVE-1510 # Conflicts: # src/Campaigns/Blocks/blocks.ts
|
@pauloiankoski this is ready for review. |
pauloiankoski
approved these changes
Feb 10, 2025
There was a problem hiding this comment.
@alaca I just left a comment in an entry that I believe it's a leftover. Other than that, the code looks really good and I liked how you implemented it using the app component in the renderer. Solving that possible leftover, this is ready for QA, which's is why I'm approving this PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR is based on #7687 which should be reviewed first.
This pull request introduces several new features and improvements to the campaign functionality, including the addition of a new block for the campaign goal, as well as enhancements to existing components. The most significant changes include the implementation of the new block and updates to the campaign model and controller.
Testing Instructions
Pre-review Checklist
@unreleasedtags included in DocBlocks