Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Skip Recording Payment Status Change If No Modification #7748

Merged

Conversation

yiedpozi
Copy link
Contributor

Description

  • Skip recording a payment status change in the donation note if the status remains unchanged.

Visuals

image

Updating donation status to Complete, but the donation status is already set as Complete. A donation note for payment status change still will be recorded.

Testing Instructions

Try updating the donation status programatically, example:

$donation_status = DonationStatus::COMPLETE(); // use current donation status, ie: complete

$donation = Donation::find(1);
$donation->status = $donation_status;
$donation->save();

No more redundant updates on payment status change.

Copy link
Contributor

@jonwaldstein jonwaldstein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@jonwaldstein jonwaldstein merged commit 18bfc2a into impress-org:develop Feb 20, 2025
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants