ref: oracle rename #294
Draft
ref: oracle rename #294
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…x in when nst rounds grows
…py for simulation
…test, embedded aggAlgorithm, validate msg
…rices with same detID
…keys before nonce insert
…ments to explain why map iteration is safe
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Comment on lines
+174
to
+183
| } | ||
|
|
||
| // praepareRounds prepares the rounds for the next block, and returns the feederIDs of the rounds that are open on next block | ||
| func (f *FeederManager) prepareRounds(ctx sdk.Context) []int64 { | ||
| logger := f.k.Logger(ctx) | ||
| feederIDs := make([]int64, 0) | ||
| height := ctx.BlockHeight() | ||
| // it's safe to range map directly, this is just used to update memory state | ||
| for _, r := range f.rounds { | ||
| if open := r.PrepareForNextBlock(ctx.BlockHeight()); open { |
Check warning
Code scanning / CodeQL
Iteration over map Warning
Comment on lines
+243
to
+260
| r.FinalPrice() | ||
| r.status = roundStatusClosed | ||
| } | ||
| // close all quotingWindow to skip current rounds' 'handlQuotingMisBehavior' | ||
| if f.forceSeal { | ||
| r.closeQuotingWindow() | ||
| } | ||
| } | ||
| } | ||
|
|
||
| func (f *FeederManager) commitRounds(ctx sdk.Context) { | ||
| logger := f.k.Logger(ctx) | ||
| height := ctx.BlockHeight() | ||
| successFeederIDs := make([]string, 0) | ||
| // it's safe to range map directly since the sate update is independent for each feederID, however we use sortedFeederIDs to keep the order of logs | ||
| // this can be replaced by map iteration directly when better performance is needed | ||
| for _, feederID := range f.sortedFeederIDs { | ||
| r := f.rounds[feederID] |
Check warning
Code scanning / CodeQL
Iteration over map Warning
leonz789
force-pushed
the
develop-oracle-rename
branch
from
2b0e8a1 to
665a141
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
rename 'createprice' with 'pricefeed'
this PR is based on #275 , should be merged after.
NOTE:
Closes #XXX