Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Taxon detail map and taxon map screen #1218

Merged
merged 9 commits into from
Mar 27, 2024
Merged

Taxon detail map and taxon map screen #1218

merged 9 commits into from
Mar 27, 2024

Conversation

angielt
Copy link
Collaborator

@angielt angielt commented Feb 27, 2024 •
edited by kueda
Loading

-Taxon Detail map and map screen

  • Moved DetailsTab to SharedComponents
  • Map Preview may take a while to load and the change between map locations can be seen when you switch to a different taxon detail page (TODO: add a loading indicator for map preview or change how it loads)

Closes #872
Closes #1233

kueda
kueda requested changes Feb 28, 2024
View reviewed changes
Copy link
Member

@kueda kueda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The map on TaxonDetails is not showing observation tiles for that taxon. It looks like it's showing tiles for all observations. It's also not zooming in on the extent of the taxon's observations.

@kueda kueda changed the title 872 taxon detail map and taxon map screen Taxon detail map and taxon map screen Mar 27, 2024
kueda added 2 commits March 26, 2024 17:19
@kueda
Several minor fixes
521307f 
* disable interaction on TaxonDetails map
* disable SpeciesSeenCheckmark when signed out
* Remove x margin on TaxonDetails map
* Fix broken region calculation on TaxonDetails map
* Ensure TaxonDetails map uses same obs search params for bounds calculation
  and tiles
@kueda
DetailsMap updates
1965c36 
* Removed containers that weren't adding much logic
* Restyled ObsDetail map model per spec
* Disabled interaction for maps on TaxonDetails and ObsDetails (closes #1233)
kueda
kueda approved these changes Mar 27, 2024
View reviewed changes
Copy link
Member

@kueda kueda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI, I fixed a few things. Maybe more than a few. The bit that's probably the most worth your time to review is calculating the region given the observation bounds in 521307f#diff-f6d6a4b58e8ce0a2bb53983d3cc7c751763ff752af8b926ebba9d3f54bae3fc7

@angielt angielt merged commit 4b61a30 into main Mar 27, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kueda kueda kueda approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Disable map interaction on ObsDetails and TaxonDetails Taxon Detail map and Taxon Map screen
2 participants
@angielt @kueda