Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proposal for the evolution of the html panel for presenting emails #682

Open
wants to merge 21 commits into
base: master
Choose a base branch
from

Conversation

Need74
Copy link
Contributor

@Need74 Need74 commented Sep 17, 2024

Hi

I propose to you through this PR a small evolution of the presentation of the html panel of presentation of the mails
I formatted some selection zones that were badly sized or positioned.
I went back for the font size (85%) of the comments in the options page because, even if the orange background color is of a very nice effect it does not allow to see as quickly where are the choices to be made when one has well appropriated the software.
I added a space after "custom feed:"
I limited the size of the zone just after "Truncate notifications longer than" which does not need to contain such a large number.
I removed the centering of the text "Only fire desktop and sound notifications when email has arrived in less than (in minutes): " so that it is aligned with the others.
I modified the size of the "expand" button so that it does not interfere with the text of the emails and that it is better seen.
I added an icon for the "mark as read" button
I therefore assigned it a label like the other buttons.
I added labels for the "expand" "next" and "previous" buttons but I couldn't make them black like those in the small toolbar at the bottom.
I named these labels "Expand <==> Reduce", "Previous email" and "Next email"

As I am not a programmer and I was only inspired by your work to create these things, it is not impossible that there are things to take up again because this is my first experience with HTML coding.

I hope you like it or that it will inspire you for a future evolution.

Best regards

Denis G

PS:

I just realized that my fork was not very up to date (a month or more) and therefore the proposed changes seem to be much more numerous than reality. I don't know if Github will summarize with the version currently online or if you will have to do it manually but in all there are only about fifteen lines modified.

@inbasic
Copy link
Owner

inbasic commented Sep 18, 2024

Could you split the changes into separate merge requests? One for the options page and another for the popup changes, both based on the latest commit. It's difficult to review when the changes conflict with the main branch. I also suggest not to modify locales (except en locale) here. We are going to update from Transifex anyway.

I added an icon for the "mark as read" button

Also, please revert the addition of the icon for the "mark as read" button. Gmail used to have a label for this, which is part of the classic view I'd like to keep.

I named these labels "Expand <==> Reduce"

You can use "Switch between expanded and collapsed view" instead.

@Need74
Copy link
Contributor Author

Need74 commented Sep 18, 2024

Could you split the changes into separate merge requests? One for the options page and another for the popup changes, both based on the latest commit. It's difficult to review when the changes conflict with the main branch. I also suggest not to modify locales (except en locale) here. We are going to update from Transifex anyway.

I added an icon for the "mark as read" button

Also, please revert the addition of the icon for the "mark as read" button. Gmail used to have a label for this, which is part of the classic view I'd like to keep.

I named these labels "Expand <==> Reduce"

You can use "Switch between expanded and collapsed view" instead.

Hi

Thanks for the answer.
As I am learning to make changes on several files in a PR, I did the work from my fork and I see that it is not relevant at all.
I will redo the work and separate the popup changes [the option page changes will stay on my first PR] and will work from the main branch of Github with a new PR.

About the icon for the "mark as read" button, do you want me to do nothing and leave it as is with text on the button and no label or do you want to use your own icon?
I made this change mainly because the text in French (and in other languages ​​like German for example) is too long for the size of the current button. If your wish is to leave the text on the button I think you should leave this text untranslated there but add a label for this button with the possible translation of this label.

For the "Expand" label I propose to use for harmony with the dark theme: "Toggle expanded view on and off"

I will wait for the locale change for the (en) version and will do the work in (fr) from Transifex (and also in (it) for this language)
I will close this PR after that but I don't know how to go back to cancel a change.
Kind regards

@Need74
Copy link
Contributor Author

Need74 commented Sep 18, 2024

Hi

I have canceled all the changes for the panel and I will make a new PR specially for the evolution of the panel separately.
Regards

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants