-
Notifications
You must be signed in to change notification settings - Fork 116
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Proposal for the evolution of the html panel for presenting emails #682
base: master
Are you sure you want to change the base?
Conversation
A new icon more pretty than a text
the french part or my PR
The English part of my PR
Could you split the changes into separate merge requests? One for the options page and another for the popup changes, both based on the latest commit. It's difficult to review when the changes conflict with the main branch. I also suggest not to modify locales (except en locale) here. We are going to update from Transifex anyway.
Also, please revert the addition of the icon for the "mark as read" button. Gmail used to have a label for this, which is part of the classic view I'd like to keep.
You can use "Switch between expanded and collapsed view" instead. |
Hi Thanks for the answer. About the icon for the "mark as read" button, do you want me to do nothing and leave it as is with text on the button and no label or do you want to use your own icon? For the "Expand" label I propose to use for harmony with the dark theme: "Toggle expanded view on and off" I will wait for the locale change for the (en) version and will do the work in (fr) from Transifex (and also in (it) for this language) |
For buttons label
Hi I have canceled all the changes for the panel and I will make a new PR specially for the evolution of the panel separately. |
Hi
I propose to you through this PR a small evolution of the presentation of the html panel of presentation of the mails
I formatted some selection zones that were badly sized or positioned.
I went back for the font size (85%) of the comments in the options page because, even if the orange background color is of a very nice effect it does not allow to see as quickly where are the choices to be made when one has well appropriated the software.
I added a space after "custom feed:"
I limited the size of the zone just after "Truncate notifications longer than" which does not need to contain such a large number.
I removed the centering of the text "Only fire desktop and sound notifications when email has arrived in less than (in minutes): " so that it is aligned with the others.
I modified the size of the "expand" button so that it does not interfere with the text of the emails and that it is better seen.
I added an icon for the "mark as read" button
I therefore assigned it a label like the other buttons.
I added labels for the "expand" "next" and "previous" buttons but I couldn't make them black like those in the small toolbar at the bottom.
I named these labels "Expand <==> Reduce", "Previous email" and "Next email"
As I am not a programmer and I was only inspired by your work to create these things, it is not impossible that there are things to take up again because this is my first experience with HTML coding.
I hope you like it or that it will inspire you for a future evolution.
Best regards
Denis G
PS:
I just realized that my fork was not very up to date (a month or more) and therefore the proposed changes seem to be much more numerous than reality. I don't know if Github will summarize with the version currently online or if you will have to do it manually but in all there are only about fifteen lines modified.