use constructor instead of property injection so mocked services can …

…be passed
inbo · Feb 19, 2025 · 4402a8d · 4402a8d
1 parent a75093a
commit 4402a8d
Show file tree

Hide file tree

Showing 3 changed files with 13 additions and 8 deletions.
diff --git a/projects/ng-inbo/src/lib/components/autocomplete/inbo-autocomplete.component.ts b/projects/ng-inbo/src/lib/components/autocomplete/inbo-autocomplete.component.ts
@@ -41,7 +41,9 @@ export class InboAutocompleteComponent<T extends Partial<{ [key: string]: any }>
   items: Array<T>;
   errorStateMatcher = new CustomErrorStateMatcher(() => this.showErrorMessage);
 
-  private changeDetectorRef = inject(ChangeDetectorRef);
+
+  constructor(public changeDetectorRef: ChangeDetectorRef){}
+
   private _value: T;
 
   get value(): T {

diff --git a/projects/ng-inbo/src/lib/components/autocomplete/test/inbo-autocomplete.component.spec.ts b/projects/ng-inbo/src/lib/components/autocomplete/test/inbo-autocomplete.component.spec.ts
@@ -22,9 +22,7 @@ describe('InboAutocompleteComponent', () => {
     changeDetectorRef = mock(ChangeDetectorRefTestImpl);
     mockSearchFunction = fnmock();
 
-    componentUnderTest = new InboAutocompleteComponent(
-      instance(changeDetectorRef),
-    );
+    componentUnderTest = new InboAutocompleteComponent(changeDetectorRef);
     componentUnderTest.searchFunction = mockSearchFunction;
   });
 
@@ -125,6 +123,9 @@ describe('InboAutocompleteComponent', () => {
     beforeEach(() => {
       itemsSubject = new Subject<Array<TestObject>>();
       componentUnderTest.searchFunction = () => itemsSubject.asObservable();
+
+      changeDetectorRef = mock(ChangeDetectorRefTestImpl);
+      componentUnderTest = new InboAutocompleteComponent(changeDetectorRef);
     });
 
     it('should not do a search and set items to empty array if the given string has a length of less than the minimum number of characters', () => {

diff --git a/projects/ng-inbo/src/lib/components/data-table/test/inbo-data-table.component.spec.ts b/projects/ng-inbo/src/lib/components/data-table/test/inbo-data-table.component.spec.ts
@@ -1,8 +1,9 @@
-import {InboDataTableComponent} from '../inbo-data-table.component';
+import { InboDataTableColumnConfiguration } from '../column-configuration.model';
+import {InboDataTableComponent, InboDatatableItem} from '../inbo-data-table.component';
 
 describe('InboDataTableComponent', () => {
 
-  let componentUnderTest: InboDataTableComponent<TestDataClass>;
+  let componentUnderTest: InboDataTableComponent<any>;
 
   beforeEach(() => {
     componentUnderTest = new InboDataTableComponent();
@@ -17,13 +18,14 @@ describe('InboDataTableComponent', () => {
         },
         propA: {
           name: 'Property A',
-        },
-      };
+        }
+      } as InboDataTableColumnConfiguration<InboDatatableItem>; // Explicitly cast
 
       componentUnderTest.ngOnInit();
 
       expect(componentUnderTest.displayedColumns).toEqual(['id', 'propA']);
     });
+
   });
 
 });