Improve timer commands and checking types #39
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
longquanzheng
commented
Oct 30, 2024
| def timer_command_by_duration( | ||
| cls, duration: timedelta, command_id: Optional[str] = None | ||
| ): | ||
| def by_seconds(cls, duration_seconds: int, command_id: Optional[str] = None): |
There was a problem hiding this comment.
rename this method as I realized that's a bit awkward to use TimerCommand.timer_command_by_duration(...), and renamed to TimerCommand.by_seconds() looks more concise.
I will put this as a breaking changes in the release.
Luckily our internal users didn't use this API. they use the constructor directly
lwolczynski
approved these changes
Oct 30, 2024
stevo89519
approved these changes
Oct 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.