Deprecate tctl in favor of new Temporal CLI #317
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #317 +/- ##
=======================================
Coverage 71.46% 71.46%
=======================================
Files 54 54
Lines 4419 4419
=======================================
Hits 3158 3158
Misses 1024 1024
Partials 237 237 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
zklgame
reviewed
Aug 4, 2023
CONTRIBUTING.md
Outdated
|
|
||
| NOTE: For local testing it's recommended to use [temporal docker-compose](https://github.com/temporalio/docker-compose) | ||
| Alternatively, you could just build the binary by `make bins` and then run `./iwf-server start` |
There was a problem hiding this comment.
Or, directly using the command line in a terminal under the iwf folder:
go run cmd/server/main.go start
There was a problem hiding this comment.
good idea. I never used this but just tried it and it works :D
zklgame
reviewed
Aug 4, 2023
CONTRIBUTING.md
Outdated
|
|
||
| `make temporalIntegTests` | ||
|
|
||
| To run the server, if you are in an IDE, you can run the main function in `./cmd/main.go` with argument `start`. | ||
|
|
||
| Alternatively, you could just build the binary by `make bins` and then run `./iwf-server start` |
There was a problem hiding this comment.
These two sentences here are the same as the line 80 and 82?
There was a problem hiding this comment.
yeah that's not nice. I just moved them to the same place.
zklgame
approved these changes
Aug 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
for #313