CIRC-2136 fix for npe in check for floating

-- when current process is not a check-in but a page request
indexdata · Sep 23, 2024 · 261420d · 261420d
1 parent bf8f964
commit 261420d
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 3 deletions.
diff --git a/src/main/java/org/folio/circulation/domain/Item.java b/src/main/java/org/folio/circulation/domain/Item.java
@@ -357,8 +357,9 @@ public String getFloatDestinationLocationId() {
   }
 
   public boolean canFloatThroughCheckInServicePoint() {
-    return getLocation() != null &&
-      getLocation().isFloatingCollection()
+    return getLocation() != null
+      && getLocation().isFloatingCollection()
+      && getFloatDestinationLocation() != null
       && getFloatDestinationLocation().getId()  != null;
   }
 

diff --git a/src/main/java/org/folio/circulation/infrastructure/storage/inventory/ItemRepository.java b/src/main/java/org/folio/circulation/infrastructure/storage/inventory/ItemRepository.java
@@ -113,7 +113,7 @@ public CompletableFuture<Result<Item>> updateItem(Item item) {
     if (item.isInStatus(IN_TRANSIT)) {
       write(updatedItemRepresentation, IN_TRANSIT_DESTINATION_SERVICE_POINT_ID,
         item.getInTransitDestinationServicePointId());
-    } else if (item.canFloatThroughCheckInServicePoint()) {
+    } else if (item.isInStatus(AVAILABLE) && item.canFloatThroughCheckInServicePoint()) {
       remove(updatedItemRepresentation, TEMPORARY_LOCATION_ID);
       write(updatedItemRepresentation, TEMPORARY_LOCATION_ID,
         item.getFloatDestinationLocationId());