Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UIHAADM-98: Display Datepicker in full view #60

Merged
merged 2 commits into from
Dec 4, 2023
Merged

UIHAADM-98: Display Datepicker in full view #60

merged 2 commits into from
Dec 4, 2023

Conversation

mkuklis
Copy link
Contributor

@mkuklis mkuklis commented Dec 4, 2023

https://issues.folio.org/browse/UIHAADM-98

Display Datepicker in full view by using usePortal prop.

datepicker

@mkuklis mkuklis requested a review from MikeTaylor December 4, 2023 14:45
Copy link
Collaborator

@MikeTaylor MikeTaylor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So much better! Thank you for finding this.

@@ -26,6 +26,8 @@ function renderSingleDateFilter(intl, filterStruct, updateQuery, field, boundary
updateQuery({ filters: deparseFilters(fs2) });
}}
useInput
usePortal
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe you should fix the comment higher up the file that says "usePortal" doesn't fix this?

Copy link

sonarqubecloud bot commented Dec 4, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@mkuklis mkuklis merged commit eba0eee into main Dec 4, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants