Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

YAZ 5.34.1 breaks search with OCLC's "Sisis InfoGuide" origin #129

Merged

Conversation

jakub-id
Copy link
Contributor

No description provided.

@jakub-id jakub-id linked an issue Sep 16, 2024 that may be closed by this pull request
@jakub-id jakub-id changed the title Yaz 5.34.1 breaks search with OCLC SISIS infoguide origin YAZ 5.34.1 breaks search with OCLC's "Sisis InfoGuide" origin Sep 16, 2024
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hate pre releases. Up to you

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. I'll make proper release once confirmed.

@@ -343,7 +343,7 @@ const char *cql_lookup_reverse(cql_transform_t ct,
Z_AttributeElement a_ae = *attributes->attributes[j];
if (!compare_attr(e_ae, &a_ae))
break;
if (a_ae.attributeSet && e_ae->attributeSet &&
if (a_ae.attributeSet &&
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fine.

@jakub-id
Copy link
Contributor Author

This has now been confirmed by ZIB to fix the problem. I will merge and make a final 5.34.2 release seperately.

@jakub-id jakub-id merged commit dde3434 into master Sep 19, 2024
3 checks passed
@jakub-id jakub-id deleted the 127-yaz-5341-breaks-search-with-oclcs-sisis-infoguide-origin branch September 19, 2024 09:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

YAZ 5.34.1 breaks search with OCLC's "Sisis InfoGuide" origin
2 participants