Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AStarBox Plugin #962

Merged
merged 14 commits into from
Aug 30, 2024
Merged

AStarBox Plugin #962

merged 14 commits into from
Aug 30, 2024

Conversation

mcgillca
Copy link
Contributor

An indi plug in for AStarBox. This controls a HAT on a Raspberry Pi 5 that provides power for astro devices and a dew heater.

Find full details here: AStarBox

Initial version of AStarBox as a 3rd-party driver.
New version detects if there is a problem or not with the I2C connection.

Also, changed the names to be consistent with Rodolphe's files. (AStarBox vs CAStarBox), and changed astarbox to indi-astarbox.
Update to improve format.
Again change format.
Formatting again
Another format change.
I hope I have this right now!
Getting name right in Readme
Called openAllPorts into connect so can use results to indicate whether connection successful  or not.

Moved getPortPWM for ports 5 and 6 into connect too - when in openAllPports m_bLinked was false at that point so no values collected.

Now called after m_bLlinked is true so that values are collected.
Merged Rodolphe's updates and mine.

m_bPortsOpen is tested before opening all ports, but getting PWM5 and 6 is now in connect.
Replaced 5 and 6 by their ENUMS instead for consistency.
@knro knro self-assigned this Aug 20, 2024
Previously, setting PWM to zero turned the port off. However, this prevented the status from being read so that if changed elsewhere, it would not be picked up.

Now, the ports are left on though with power of zero (same as turned off from a physical perspective).

Also, tidied up the return codes from setPortPWMDutyCyclePercent since this returns an integer rather than a bool,
@knro
Copy link
Collaborator

knro commented Aug 21, 2024

Thank you! Do you have driver documentation with screenshots of each tab? We need to add it to INDI Documentation.

@mcgillca
Copy link
Contributor Author

mcgillca commented Aug 21, 2024 via email

@knro
Copy link
Collaborator

knro commented Aug 21, 2024

A google or word doc would be great, thanks!

@mcgillca
Copy link
Contributor Author

mcgillca commented Aug 21, 2024 via email

@knro
Copy link
Collaborator

knro commented Aug 21, 2024

Did you attach a file? it's not showing up on Github if you did.

@mcgillca
Copy link
Contributor Author

AStarBox Indi Driver.docx

HI - yes, I definitely included it in the email - but loaded it directly on GitHub instead.

Colin

@mcgillca
Copy link
Contributor Author

I see that some checks failed, but they seem to fail on other drivers or libraries?

Also, this is only really needed for the Arch64 architectures - while the plugin should run on other devices, it won't have anything to connect to. Not sure if there is a way to flag that?

@knro
Copy link
Collaborator

knro commented Aug 22, 2024

@naheedsa Please coordinate with Joe to add the documentation

@knro knro merged commit 0df5832 into indilib:master Aug 30, 2024
2 of 4 checks passed
@mcgillca
Copy link
Contributor Author

mcgillca commented Aug 31, 2024 via email

@knro
Copy link
Collaborator

knro commented Oct 1, 2024

@mcgillca There are some issues in the driver that prevents creating packages for it. Can you please check them out? Right now the driver is not included in INDI v2.1.0 release due to these issues.

@mcgillca
Copy link
Contributor Author

mcgillca commented Oct 1, 2024 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants