Dynamically load lines feature #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@patmigliaccio, In #3 @ines mentions that the minified version is compiled with Babel. (ref) |
|
@Saw-mon-and-Natalie, nice find! But, I was hoping there would be a bit more detail like a |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added the ability to dynamically load line elements (fixes #4) by passing an array of objects into the
lineDataproperty of theoptionsobject into the constructor ofTermynalclass.I've tried to maintain as much consistency with the existing codebase as possible, including an example and updated README. One step that would still need to be completed is updating the minification of
termynal.min.js; unsure of what tool is being used for minification, I wanted to leave that up to the creator/maintainer to keep it consistent.Also, adding a
package.jsonand pushing this tonpmwould be super. I'm a huge fan of this project and it'd be great to make it more accessible to developers.