Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

when qwen rerank model not return ok, raise exception to notice user #3593

Merged
merged 1 commit into from
Nov 22, 2024

Conversation

liwenju0
Copy link
Contributor

@liwenju0 liwenju0 commented Nov 22, 2024

What problem does this PR solve?

When calling the Qwen rerank model, if the model does not return correctly, an exception should be raised to notify the user, rather than simply returning a value of 0, as this would be confusing to the user.

Type of change

  • New Feature (non-breaking change which adds functionality)

@JinHai-CN JinHai-CN changed the title when qwern rerank model not return ok, raise exception to notice user when qwen rerank model not return ok, raise exception to notice user Nov 22, 2024
@yuzhichang yuzhichang added the ci Continue Integration label Nov 22, 2024
@yuzhichang yuzhichang merged commit 8750963 into infiniflow:main Nov 22, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci Continue Integration
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants