Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dev eventbus #91

Merged
merged 7 commits into from
Feb 20, 2024
Merged

Dev eventbus #91

merged 7 commits into from
Feb 20, 2024

Conversation

loathedrobot
Copy link
Contributor

No description provided.

@loathedrobot loathedrobot requested a review from slntopp February 20, 2024 08:28
@loathedrobot loathedrobot requested review from a team and removed request for slntopp February 20, 2024 08:30
import "google/protobuf/struct.proto";
import "google/api/annotations.proto";

enum EventType{
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's better to use word "Kind" instead of "Type"


service EventsService{
rpc Subscribe (node.EmptyMessage) returns (stream Event){
option (google.api.http) = {get: "/eventbus/stream"};
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No need for this

@loathedrobot loathedrobot requested a review from slntopp February 20, 2024 09:16
@loathedrobot loathedrobot merged commit 856836e into master Feb 20, 2024
2 checks passed
@loathedrobot loathedrobot deleted the dev-eventbus branch February 20, 2024 10:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants