Added SIFS configuration #29
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wburns
reviewed
Jul 25, 2024
|
I'll remove the other options and leave only the SIFS enabled. I want to ensure we're hitting the disk, so I'll also change the memory count. I would like to keep a separate file, though. It is easy to have the plain cache configuration, and we don't need to add steps for parsing and more branches based on flags. |
* Added files with SIFS for DIST and REPL; * Use a small value in `memory` configuration.
jabolina
force-pushed
the
add-sifs-verification
branch
from
9457185
to
ffd7971
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a configuration for DIST and REPL. TBH, I am unsure if we need to run for both modes to identify regression or if only one is enough. Also, I've set memory.max-count to a value lower than the number of entries hoping it would cause operations to go to disk.