Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(recipes): expo-router #107

Merged
merged 6 commits into from
Feb 9, 2024
Merged

feat(recipes): expo-router #107

merged 6 commits into from
Feb 9, 2024

Conversation

frankcalise
Copy link
Contributor

Description

  • Closes Implement expo-router #90
  • Implements expo-router in an Ignite v9 application
  • Demonstrates authentication flow, tab navigation, search params and universal deep linking

Copy link
Contributor

@morganick morganick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I made it up to Tab Navigation.

docs/recipes/ExpoRouter.md Show resolved Hide resolved
docs/recipes/ExpoRouter.md Outdated Show resolved Hide resolved
docs/recipes/ExpoRouter.md Show resolved Hide resolved
docs/recipes/ExpoRouter.md Show resolved Hide resolved
docs/recipes/ExpoRouter.md Outdated Show resolved Hide resolved
docs/recipes/ExpoRouter.md Show resolved Hide resolved
docs/recipes/ExpoRouter.md Outdated Show resolved Hide resolved
@Jpoliachik
Copy link
Contributor

Jpoliachik commented Jan 25, 2024

Just went through this post and updated for Expo@50 & ExpoRouter@3 compatibility

If testing, make sure to ignite a new project using expo50 branch (its not merged in as of now)

Copy link
Member

@jamonholmgren jamonholmgren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't actually go through everything, but I think it's high quality enough to ship. Nice work

@Jpoliachik Jpoliachik merged commit 75603ab into main Feb 9, 2024
1 check passed
@Jpoliachik Jpoliachik deleted the feat/expo-router branch February 9, 2024 22:18
@fbele
Copy link

fbele commented Feb 29, 2024

I want to implement Expo Router in to my app, I have tested the Recipe and everything works fine so far except for the linking from the Drawer side menu (on the left) when you're in Showroom screen. At least for me, when I tap on any of the items in the menu, the app just gets stuck in a loop and the following error occurs:

ERROR Warning: Maximum update depth exceeded. This can happen when a component calls setState inside useEffect, but useEffect either doesn't have a dependency array, or one of the dependencies changes on every render.

I think it's for the same reason, but the linking with query parameters (?itemSlug=variants&sectionSlug=toggle) also doesn't work on iOS emulator, but it does work on web app, like you described in your Recipe. I try to execute this command:

npx uri-scheme open exp://localhost:8081/--/showroom?itemSlug=variants&sectionSlug=toggle --ios

And I get the following error:

[1] 4861 zsh: no matches found: exp://localhost:8081/--/showroom?itemSlug=variants [1] + exit 1 npx uri-scheme open exp://localhost:8081/--/showroom?itemSlug=variants zsh: command not found: --ios

Which is odd, because if I understand Expo Router's documentation right, using query parameters should just work, regardless if one does anything with the data from the query or not, same as in a web browser.

Do you have more experience with this situation? I really don't have much experience with Expo Router so any help or input will be appreciated. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement expo-router
5 participants