Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(recipes): redux recipe #117

Merged
merged 4 commits into from
Jan 17, 2024
Merged

feat(recipes): redux recipe #117

merged 4 commits into from
Jan 17, 2024

Conversation

Jpoliachik
Copy link
Contributor

@Jpoliachik Jpoliachik commented Jan 16, 2024

  • How to remove Mobx-State-Tree from Ignite default project
  • How to add Redux, with example
  • Persistence with redux-persist
  • Point to Reactotron docs for installing reactotron-redux plugin

Closes #114

Copy link
Member

@robinheinze robinheinze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks awesome!!


#### Create Store

- In a new file `store.ts`, create your Redux store.
Copy link
Collaborator

@flexbox flexbox Jan 17, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what's your advice for the entire path?

./app/redux/store.ts

or something like

./app/store.ts

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not strongly opinionated, IMO it doesn't matter too much, but it seems like Redux docs suggest a store.ts at more top level app/store.ts and then creating individual slices within feature folders.
https://redux.js.org/style-guide/#structure-files-as-feature-folders-with-single-file-logic

I'll add the full file path to be consistent with Redux's suggestion 👍

@Jpoliachik Jpoliachik merged commit 5576dcc into main Jan 17, 2024
1 check passed
@Jpoliachik Jpoliachik deleted the feat/redux branch January 17, 2024 19:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add redux recipe
3 participants