Dynamically display ignite release versions #135
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cdanwards
commented
Feb 26, 2024
frankcalise
approved these changes
Feb 26, 2024
lindboe
approved these changes
Feb 26, 2024
cdanwards
added a commit
that referenced
this pull request
Feb 28, 2024
* Add LatestRelease component and update notificationSection styles * Fix key warning in FreshRecipes component * Fix typo in YAML heading * Added comment * Refactor recipe link key in FreshRecipes component * Update LatestVersion component title * Refactor LatestRelease component to use ReleaseRemark component * Refactor releaseString logic in LatestVersion component
cdanwards
added a commit
that referenced
this pull request
Feb 28, 2024
* Add LatestRelease component and update notificationSection styles * Fix key warning in FreshRecipes component * Fix typo in YAML heading * Added comment * Refactor recipe link key in FreshRecipes component * Update LatestVersion component title * Refactor LatestRelease component to use ReleaseRemark component * Refactor releaseString logic in LatestVersion component
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This feature dynamically displays the latest Ignite release on the homepage. It fetches release info from GitHub API, showing the version and how many days ago it was released and falls back to a generic GitHub link to `/latest/ if unable to fetch.
This approach seemed simpler than trying to implement a GH Action or using a version badge for the same info, but if we're not happy to include an API call on this site let me know :)
I also included 2 small fixes I noticed while working on this.