Making headers clickable and aligning text #151
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lindboe
reviewed
Mar 26, 2024
|
|
||
| // Bringing in the styles from the `pages/index.module.css` file to not have to duplicate the styles (nothing is new in this component) | ||
| import styles from "../../pages/index.module.css"; | ||
| import * as Arrow from "@site/static/img/arrow.svg"; | ||
| import styles from "../../pages/index.module.css" |
There was a problem hiding this comment.
A lot of this looks like conflicting formatter churn. Can we either:
a. avoid committing the code style changes (I'm assuming this means disable your default formatting settings that you may have in your editor for this workspace)
b. add configuration to the project to use for formatting
I personally prefer option A, because I don't want to maintain more formatting config than I have to, but low GAFO.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
While I was reviewing a recipe, I noticed the new recipe title and Ignite title were not clickable. They were they same color as the links on the page and I kept trying to click them each time I visited.
Solution
Make the headers links for ease of navigation. Also align the text between the two columns so they have the same visual cadence. I'm using xScope for the guilds so you can seen the alignment.
plain_headers.mov
linked_headers.mov
mobile_linked_headers.mov