Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

recipe: update vision camera to use hooks #182

Merged
merged 2 commits into from
Jan 8, 2025
Merged

Conversation

ecroce
Copy link
Contributor

@ecroce ecroce commented Nov 20, 2024

Was looking into #136 and while the issue mentioned doesn't appear to be reproducible, there are a few areas of the recipe that were throwing/out of date. Moved to using the hooks API from react-native-vision-camera in lieu of the imperative API which we were already doing for the barcode scanning.

Sources:
https://react-native-vision-camera.com/docs/guides#gettingrequesting-permissions
https://react-native-vision-camera.com/docs/guides/code-scanning

Open Source License Notice for Contributors

If you are contributing a recipe to this repository, you agree to license your contribution under the terms of the CC BY-SA 4.0 license.

If you have any questions, please reference the CONTRIBUTING.md or LICENSE.md file for more information.

Thank you for your contribution!

@@ -6,7 +6,7 @@ tags:
- MobX
- State Management
last_update:
author: Justin Poliachik
author: Ellie Croce
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Forgot to update in last PR

@ecroce ecroce marked this pull request as ready for review November 20, 2024 16:17
@ecroce ecroce linked an issue Nov 20, 2024 that may be closed by this pull request
Copy link
Contributor

@frankcalise frankcalise left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, thanks! sorry I missed this hanging out there

@ecroce ecroce merged commit b42fd63 into main Jan 8, 2025
1 check passed
@ecroce ecroce deleted the update-vision-camera-recipe branch January 8, 2025 17:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Camera Recipe: react-native-vision-camera recipe doesn't work.
2 participants