Minor improvements and tidying up of SwiftUI tech test #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mhoughton-iw
commented
Dec 12, 2022
| @@ -0,0 +1,15 @@ | |||
| <?xml version="1.0" encoding="UTF-8"?> | |||
There was a problem hiding this comment.
Launch Screens can now be done entirely within Info.plist without the need to maintain a storyboard.
| guard let url = URL(string: NetworkService.baseUrl + "/authorities/basic") else { | ||
| return .failure(AuthoritiesFetcherError.invalidURL) | ||
| throw AuthoritiesFetcherError.invalidURL |
There was a problem hiding this comment.
Updated this to make use of the throw in the method signature
| @@ -0,0 +1,69 @@ | |||
| // | |||
There was a problem hiding this comment.
Added some basic test coverage to encourage applicants to discuss with interviewers what tests they would add if they had more time.
| .font(.subheadline) | ||
| .foregroundColor(.gray) | ||
| } | ||
| } |
There was a problem hiding this comment.
Simple error view for if network request fails.
| .alert("Copyright © 2022 Infinity Works, Part of Accenture.", isPresented: $showingCopyright) { | ||
| } message: { | ||
| Text("All rights reserved.") | ||
| } |
There was a problem hiding this comment.
The new launch screen loses the copyright message, so I added it as a toolbar button alert instead.
johnWilliamG
approved these changes
Jan 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.