-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change development prerequisites template #77
base: master
Are you sure you want to change the base?
Conversation
|
||
* git repository - [LINK-TO-GIT-REPO](LINK-TO-GIT-REPO) <!-- https://github.com/path-to-project --> <!-- DEVELOPER --> | ||
* development and staging secrets - [LINK-TO-GIT-REPO](LINK-TO-GIT-REPO) <!-- https://github.com/path-to-project --> <!-- DEVELOPER --> | ||
* bugsnag project - [LINK-TO-BUGSNAG](LINK-TO-BUGSNAG) <!-- https://bugsnag.com/path-to-project --> <!-- DEVELOPER --> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
e a semahpre and bugsnag (and other 3rd party services) we have already listed in
https://github.com/infinum/default_rails_template/blob/master/docs/architecture/services.md
do we want to somehow reuse it or are we fine with duplicating?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, i saw that yesterday after i pushed this. I don't know actually 🤷♀️ Do you have a suggestion?
I like that we have everything here in one place that's necessary for a developer to start to work on a project
I also don't like duplication, but not sure how to solve it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah, dont know either. coz mailgun is in that services but its access is solved via 1passowrd vault :D
also should bugsnag and semaphore be something a team lead give access to?
|
||
* git repository - [LINK-TO-GIT-REPO](LINK-TO-GIT-REPO) <!-- https://github.com/path-to-project --> <!-- DEVELOPER --> | ||
* development and staging secrets - [LINK-TO-GIT-REPO](LINK-TO-GIT-REPO) <!-- https://github.com/path-to-project --> <!-- DEVELOPER --> | ||
* bugsnag project - [LINK-TO-BUGSNAG](LINK-TO-BUGSNAG) <!-- https://bugsnag.com/path-to-project --> <!-- DEVELOPER --> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah, dont know either. coz mailgun is in that services but its access is solved via 1passowrd vault :D
also should bugsnag and semaphore be something a team lead give access to?
|
||
* project in the project management software (productive, jira, etc) - [LINK-TO-PROJECT](LINK-TO-PROJECT) <!-- https://app.productive.io/path-to-project --> <!-- DEVELOPER --> | ||
* project Slack channels | ||
* [#internal-channel-name](LINK-TO-SLACK-CHANNEL) <!-- https://infinum.slack.com/path-to-project --> <!-- DEVELOPER --> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
add to codeowners as well? :)
* semaphore project - **LINK-TO-SEMAPHORE** <!-- https://semaphoreci.com/path-to-project --> <!-- DEVELOPER --> | ||
* staging and/or UAT server | ||
|
||
* git repository - [LINK-TO-GIT-REPO](LINK-TO-GIT-REPO) <!-- https://github.com/path-to-project --> <!-- DEVELOPER --> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this can be given by a team lead or a github team maintainer
@nikajukic I believe this PR is out of date and has been covered in some of the later PRs, can we close it? |
Task: No task
Aim
Use links in markdown for listing development prerequisites
Solution
Change the template for filling out development prerequisites
Move 1password to project manager group
Added internal and client slack channels