Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/mac support #46

Merged
merged 36 commits into from
Feb 11, 2025
Merged

Feature/mac support #46

merged 36 commits into from
Feb 11, 2025

Conversation

ZvonimirMedak
Copy link
Collaborator

Summary

Added macOS support with a new SwiftUI example

Changes

  • Podspec updated (removed CustomLocation from default podspec, added macOS support)
  • Added a new SwiftUI example (we will most likely need to add the SPM every time the project is downloaded since currently it has my local path)
  • Added macOS target to the UIKit example
  • Added macOS support to the DeviceTool
  • exposed SentinelTabBarView to be public
  • refactored Preferences to use PreferenceSection so that the users can't add other items than Toggle ones (We will introduce other ones later on or maybe we can set it to toggle/custom)

Type

  • Feature: This pull request introduces a new feature.
  • Bug fix: This pull request fixes a bug.
  • Refactor: This pull request refactors existing code.
  • Documentation: This pull request updates documentation.
  • Other: This pull request makes other changes.

Additional information

  • This pull request introduces a breaking change.

Description

I've mentioned everything in the changes section

Checklist

  • I have performed a self-review of my own code.
  • I have tested my changes, including edge cases.
  • I have added necessary tests for the changes introduced (if applicable).
  • I have updated the documentation to reflect my changes (if applicable).

Additional notes

After this gets reviewed, I would like to try to push team members to try out the new version where possible so we can test it out. Also, I would like to improve the current state of the navigation on macOS

@ZvonimirMedak ZvonimirMedak added documentation Improvements or additions to documentation enhancement New feature or request labels Jan 20, 2025
@ZvonimirMedak ZvonimirMedak added this to the 2.0.0 milestone Jan 20, 2025
@ZvonimirMedak ZvonimirMedak self-assigned this Jan 20, 2025
Copy link
Member

@nikolamajcen nikolamajcen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is such a great work 👍 I'm glad that I can finally run Sentinel on macOS.

Based on your changes, I've added some comments so please check them out.

Example/MacOSExample/AppDelegate.swift Show resolved Hide resolved
Example/MacOSExample/AppDelegate.swift Outdated Show resolved Hide resolved
Example/MacOSExample/AppDelegate.swift Outdated Show resolved Hide resolved
Example/MacOSExample/ViewController.swift Outdated Show resolved Hide resolved
Example/Podfile Outdated Show resolved Hide resolved
Sentinel/Classes/Core/Internal/DeviceTool.swift Outdated Show resolved Hide resolved
Sentinel/Classes/Core/Trigger.swift Outdated Show resolved Hide resolved
Sentinel/Classes/TextEditing/TextEditingToolView.swift Outdated Show resolved Hide resolved
Sentinel/Classes/UserDefaults/UserDefaultsToolView.swift Outdated Show resolved Hide resolved
SwiftUIExample/SwiftUIExample/ContentView.swift Outdated Show resolved Hide resolved
@nikolamajcen
Copy link
Member

Also, one additional note; I've seen you've done a lot of work, but you've mixed that into bigger PRs, e.g. podspec update, macOS support, preferences update. On the other PR there are multiple topics as well.

Try to separate them in future PR for easier review process and separation of concerns. The work you did is great, but this can make things easier to understand and will produce quicker review times.

@ZvonimirMedak
Copy link
Collaborator Author

@jcavar which osx version should we support? Currently, we added 12.0 support but if you think that we can up it to 13 we could use NavigationStack on MacOS. Which OS X versions do we use on our projects? Would the benefits of upping it to 13 be greater than the losses?

Copy link
Member

@nikolamajcen nikolamajcen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @ZvonimirMedak , nice work, for real! This is amazing.

Just one change and I think we are good to go; in the root folder I can se SwiftUIExample folder which I think can be removed in this scenario. Once you get rid of that, you can merge - I'm approving it already.

@ZvonimirMedak ZvonimirMedak merged commit 51c83f2 into master Feb 11, 2025
1 check passed
@ZvonimirMedak ZvonimirMedak deleted the feature/mac-support branch February 11, 2025 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants