-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/mac support #46
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is such a great work 👍 I'm glad that I can finally run Sentinel on macOS.
Based on your changes, I've added some comments so please check them out.
Also, one additional note; I've seen you've done a lot of work, but you've mixed that into bigger PRs, e.g. podspec update, macOS support, preferences update. On the other PR there are multiple topics as well. Try to separate them in future PR for easier review process and separation of concerns. The work you did is great, but this can make things easier to understand and will produce quicker review times. |
@jcavar which osx version should we support? Currently, we added 12.0 support but if you think that we can up it to 13 we could use NavigationStack on MacOS. Which OS X versions do we use on our projects? Would the benefits of upping it to 13 be greater than the losses? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @ZvonimirMedak , nice work, for real! This is amazing.
Just one change and I think we are good to go; in the root folder I can se SwiftUIExample folder which I think can be removed in this scenario. Once you get rid of that, you can merge - I'm approving it already.
Feature/navigation update
Summary
Added macOS support with a new SwiftUI example
Changes
Type
Additional information
Description
I've mentioned everything in the changes section
Checklist
Additional notes
After this gets reviewed, I would like to try to push team members to try out the new version where possible so we can test it out. Also, I would like to improve the current state of the navigation on macOS