feat: specify http completion for async queries #632
Conversation
| @@ -115,9 +116,13 @@ public ApiClient(string basePath = "http://localhost/api/v2") | |||
| string path, Method method, List<KeyValuePair<string, string>> queryParams, object postBody, | |||
| Dictionary<string, string> headerParams, Dictionary<string, string> formParams, | |||
| Dictionary<string, FileParameter> fileParams, Dictionary<string, string> pathParams, | |||
| string contentType) | |||
| string contentType, | |||
| HttpCompletionOption httpCompletionOption = HttpCompletionOption.ResponseContentRead) | |||
There was a problem hiding this comment.
@bednar I am still hitting the buffer limit in 4.16.0 for large queries was the default suppose to be HttpCompletionOption.ResponseHeadersRead?
There was a problem hiding this comment.
This is the default value that should be overridden in our files. It seems like HttpCompletionOption.ResponseHeadersRead should also be set in the QueryApi file. As a workaround, can you try setting HttpClient.MaxResponseContentBufferSize in HttpClient? How to use a custom HttpClient is mentioned here: #528.
For more information, see:
There was a problem hiding this comment.
I've created a prerelease version of the client with a fix from #649. Can you test the version 4.17.0-dev.headers.read.1? You can find it here: https://www.nuget.org/packages/InfluxDB.Client/4.17.0-dev.headers.read.1.
There was a problem hiding this comment.
Hi thank you for the response. I tested the changes for #649 and it fixed the issue.
Closes #566
Proposed Changes
Use
HttpCompletionOption.ResponseHeadersReadfor async queries for possibility to use large queries then 2GiB. For more info see related issue.For more info see: https://www.stevejgordon.co.uk/using-httpcompletionoption-responseheadersread-to-improve-httpclient-performance-dotnet
Checklist
dotnet testcompletes successfully