fix(influx2otel): only map to histogram when all fields match #314
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When AddPoint is called with the unknown metric type, it tries to infer the type from the given field names. Right now it infers histogram when any of the fields matches the histogram keys, but that leads to a lot of errors when your data isn't actually a histogram. Instead, only infer a histogram if all fields match the expected histogram keys.
|
cc @jacobmarble I see you listed as the code owner on the otel collector side |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When AddPoint is called with the unknown metric type, it tries to infer the type from the given field names. Right now it infers histogram when any of the fields matches the histogram keys, but that leads to a lot of errors when your data isn't actually a histogram. Instead, only infer a histogram if all fields match the expected histogram keys.
Fixes #312
and maybe also influxdata/telegraf#14371 ?