-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: update retention rule for CLOUD and OSS #7016
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for doing this: I have one suggestion about how to convert this to a ternary. Otherwise, it looks good to me. Let me confer with the folks working on the OSS backend to ensure the OSS-specific change is correct.
src/buckets/components/createBucketForm/UpdateBucketOverlay.tsx
Outdated
Show resolved
Hide resolved
08aeb3f
to
5cd6dca
Compare
Hi @wdoconnell. Thank for the review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good now from a UI perspective.
Please wait on a review from folks who are closer to the OSS for a backend approval.
FYI @davidby-influx: this is the PR handed off from @philjb in Slack.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM just a comment about the linter changes
Closes #1607
Fix the bug when updating the retention period of buckets:
The recorded screen is the result when update in OSS:
Screen.Recording.2025-02-25.at.15.18.00.mov
The image is the result when update in CLOUD:
Note: I have to mock the variable CLOUD because I don't know how to run the CLOUD in my local. In the captured screen the retentionRules in the payload is not exists when send to the backend like ui team suggested

Checklist
Authors and Reviewer(s), please verify the following: