Fix typing in protobuf/extensions_element

karapace/protobuf/extensions_element.py

@@ -4,33 +4,36 @@
 """
 # Ported from square/wire:
 # wire-library/wire-schema/src/commonMain/kotlin/com/squareup/wire/schema/internal/parser/ExtensionsElement.kt
+
+from __future__ import annotations
+
 from dataclasses import dataclass
 from karapace.protobuf.kotlin_wrapper import KotlinRange
 from karapace.protobuf.location import Location
 from karapace.protobuf.utils import append_documentation, MAX_TAG_VALUE
-from typing import List, Union
 
 
 @dataclass
 class ExtensionsElement:
     location: Location
     documentation: str = ""
-    values: List[Union[int, KotlinRange]] = None
+    values: list[int | KotlinRange] | None = None
 
     def to_schema(self) -> str:
-        result = []
+        result: list[str] = []
         append_documentation(result, self.documentation)
         result.append("extensions ")
 
         formatted_values = []
-        for value in self.values:
-            if isinstance(value, int):
-                formatted_values.append(str(value))
-            elif isinstance(value, KotlinRange):
-                max_value = str(value.maximum) if value.maximum < MAX_TAG_VALUE else "max"
-                formatted_values.append(f"{value.minimum} to {max_value}")
-            else:
-                raise ValueError(f"values should be a list of integers or KotlinRange, got {value!r}")
+        if self.values is not None:
+            for value in self.values:
+                if isinstance(value, int):
+                    formatted_values.append(str(value))
+                elif isinstance(value, KotlinRange):
+                    max_value = str(value.maximum) if value.maximum < MAX_TAG_VALUE else "max"
+                    formatted_values.append(f"{value.minimum} to {max_value}")
+                else:
+                    raise ValueError(f"values should be a list of integers or KotlinRange, got {value!r}")
 
         result.append(", ".join(formatted_values))
         result.append(";\n")

mypy.ini

@@ -41,9 +41,6 @@ ignore_errors = True
 [mypy-karapace.protobuf.schema]
 ignore_errors = True
 
-[mypy-karapace.protobuf.extensions_element]
-ignore_errors = True
-
 [mypy-karapace.protobuf.protobuf_to_dict]
 ignore_errors = True