-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Minor code updates from missed open comments from #36 to the migratedown feature #37
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The code changes look fine. The commit messages and PR title needs to be descriptive of what is being changed.
All my comments have been addressed However it doesn't seem that changes related to Docker and build pertain to this PR. |
Thank you, I have removed the files for building a local image for testing. We probably should add a few of these paths into |
This PR addressed open comments from PR #36
runMigrations
function instead of explicitly checking if the dirty state handling is enabled