-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Coreference search with LSH #153
Open
f-hafner
wants to merge
43
commits into
informagi:main
Choose a base branch
from
f-hafner:flavio/coref-lsh
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- with_coref option: change name to no_corefs, default False - add options to efficiency test - bash script for multiple runs with efficiency test and different options
- no coref search, 'all', 'lsh' - update ED class and efficiency_test.py accordingly
And here is the report on performance: https://github.com/rel20/rel_coref_experiments/blob/main/tex/coreferences.pdf |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make REL more scalable by using locality-sensitive hashing to reduce search space for coreference search
Features added
1. add coref switch
search_corefs
to RELREL/src/REL/training_datasets.py
, and specifically in the functionwith_coref
. The function is called unlesssearch_corefs="off"
. For the optionlsh
, the function uses theLSHRandomProjections
class from the new modulelsh.py
in REL.with_coref
now also returns an indicator for whether a mention is identified as a coreference (along with other attributes for mentions, such as candidates etc), and this is passed on to the final output.with_coref
2.
REL.lsh.LSHRandomProjections
implements LSH with Random projections__find_coref
where we do not have ground truth)3. Efficiency tests in
scripts/
efficiency_test.py
server=True
?run_efficiency_tests.sh
that runsefficiency_test.py
with the different coref optionsInstallation (I have not reproduced this recently; let me know if it fails)
Testing
Notes/questions/to dos
I have been sitting on it for long enough now, but let me know if there is something important missing for a review.