Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Depend on main REL and get tests to pass [do not merge] #1

Closed
wants to merge 6 commits into from
Closed

Depend on main REL and get tests to pass [do not merge] #1

wants to merge 6 commits into from

Conversation

stefsmeets
Copy link
Collaborator

@stefsmeets stefsmeets commented Dec 13, 2022 •
edited
Loading

I'm opening this PR to keep track of the progress to refactor crel so that it can be integrated into rel.

What I have done:

  • Depend on main branch of REL (get rid of submodule)
  • Convert jupyter notebook to tests
  • Make the package installable and get rid of hardcoded paths
  • Allow paths to data to be specified by user

@stefsmeets
Copy link
Collaborator Author

Implementation in REL based off this branch: informagi/REL#144

@stefsmeets stefsmeets mentioned this pull request Jan 16, 2023
Merged
4 tasks
@stefsmeets stefsmeets closed this Jun 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@stefsmeets