Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test model CLI #122

Merged
merged 3 commits into from
Sep 2, 2022
Merged

Test model CLI #122

merged 3 commits into from
Sep 2, 2022

Conversation

rnbguy
Copy link
Member

@rnbguy rnbguy commented Sep 1, 2022

Closes #66

@rnbguy rnbguy self-assigned this Sep 1, 2022
@rnbguy rnbguy requested a review from hvanz September 1, 2022 15:41
@rnbguy
Copy link
Member Author

rnbguy commented Sep 1, 2022 •
edited
Loading

This PR introduces test model CLI.

  1. It generates the traces using Model.sample.
  2. Reads the trace directory for each successful operation for the latest trace.
  3. Performs a loop, for which each step is similar to test trace.

Example usage on transfer example atomkraft test model --model models/transfer.tla --keypath action.tag.

@rnbguy rnbguy marked this pull request as ready for review September 2, 2022 14:11
andrey-kuprianov
andrey-kuprianov approved these changes Sep 2, 2022
View reviewed changes
Copy link
Contributor

@andrey-kuprianov andrey-kuprianov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me; thanks for taking care of this, Rano!

We will need to tweak the CLI commands slightly, , both in Modelator and Atomkraft, including this one, but that will be next week.

@andrey-kuprianov andrey-kuprianov merged commit 9c61413 into dev Sep 2, 2022
@rnbguy rnbguy deleted the rano/test-model branch November 12, 2022 12:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrey-kuprianov andrey-kuprianov andrey-kuprianov approved these changes

@hvanz hvanz Awaiting requested review from hvanz

Assignees

@rnbguy rnbguy

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement test model subcommand
2 participants
@rnbguy @andrey-kuprianov