Fix user votes query to take into account only active round validators and their power ratios. #174
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stana-miric
approved these changes
Nov 20, 2024
dusan-maksimovic
added a commit
that referenced
this pull request
Nov 25, 2024
* Migrate Hydro & Tribute contracts to v2.0.1 (#170) * added migration from v1.1.0 to v2.0.0 for hydro contract * - modifications of hydro migration code - added tribute migration - added unit tests - fixed tribute build issue * - don't check if lock's validator is active when migrating votes - changed version to V2.0.1 * added changelog * fix user votes query (#174) * Do not allow short lockups to vote on proposals for longer liquidity deployment (#175) * Do not allow short lockups to vote on proposals for longer liquidity deployment. * ignore short lockups instead of returning error in vote() * renamed proposal's "bid_duration" to "deployment_duration" (#176) * allow longer locks in pilot rounds (#177) * prepared V2.0.1 changelog (#178)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Query user votes used to return user's voted power only as the number of LSM tokens used to vote. This gives inaccurate user's voted power for two reasons:
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
.changelogmake compileand included content of the artifacts directory into the PRmake schemaand included generated files into the PR